Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsz: exclude taps/endcaps from design area #6551

Conversation

openroad-ci
Copy link
Collaborator

No description provided.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

@oharboe FYI

@maliberty maliberty enabled auto-merge January 19, 2025 15:59
@gadfort
Copy link
Collaborator

gadfort commented Jan 19, 2025

@maliberty why should these be excluded?

@maliberty maliberty merged commit 0cd2a2b into The-OpenROAD-Project:master Jan 19, 2025
11 checks passed
@maliberty maliberty deleted the rsz-exclude-taps-area branch January 19, 2025 17:14
@maliberty
Copy link
Member

They aren't representative of user logic. If you scale the core area they go up and down. Do you feel differently?

@gadfort
Copy link
Collaborator

gadfort commented Jan 20, 2025

@maliberty yes, they occupy sites in the core, which impacts the calculation of utilization.

@oharboe
Copy link
Collaborator

oharboe commented Jan 20, 2025

As a followup, I tried to figure out what the GUI is telling versus sta::format_area [rsz::design_area] 0 and I'm unable to make an exact connection #6555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants