Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utl: provide ability to convert NaN from tcl #6566

Merged
merged 1 commit into from
Jan 22, 2025
Merged

utl: provide ability to convert NaN from tcl #6566

merged 1 commit into from
Jan 22, 2025

Conversation

gadfort
Copy link
Collaborator

@gadfort gadfort commented Jan 22, 2025

Add a string pass through to allow cpp to handle casting of NaN from tcl.

Why? The new Sta code seems to sometimes respond with NaN for the power which is causing report_power_metrics to fail

Error: reports.tcl, 118 TypeError in method 'metric_float', argument 2 of type 'double'

@gadfort gadfort requested a review from maliberty January 22, 2025 01:35
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

I think NaN from sta is probably worth some investigation as well.

@maliberty maliberty merged commit 19e09ee into The-OpenROAD-Project:master Jan 22, 2025
11 checks passed
@gadfort
Copy link
Collaborator Author

gadfort commented Jan 22, 2025

I think NaN from sta is probably worth some investigation as well.

Issue created: #6574

@gadfort gadfort deleted the handle-tcl-nan branch January 22, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadfort @maliberty