Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Absolute Number function in Maths #16

Closed
wants to merge 22 commits into from
Closed

Add Absolute Number function in Maths #16

wants to merge 22 commits into from

Conversation

Owais28
Copy link
Contributor

@Owais28 Owais28 commented Sep 26, 2022 •
edited
Loading

Describe Changes

Owais28 and others added 22 commits September 24, 2022 21:59
@Owais28
> # Welcome to the TypeScript community
227bc2c 
>
> ### Describe your change:
> * [x]  Add an algorithm?
> * [ ]  Fix a bug or typo in an existing algorithm?
> * [ ]  Documentation change?
>
> ### Checklist:
> * [x]  I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md).
> * [x]  This pull request is all my own work -- I have not plagiarized.
> * [x]  I know that pull requests will not be merged if they fail the automated tests.
> * [x]  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
> * [x]  All new JavaScript files are placed inside an existing directory.
> * [x]  All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
>   **Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not
> * [x]  All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
> * [x]  If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`.
@Owais28
Added Quick Select Algorithm #6
cc8c0c7
@Owais28
Update QuickSelect.ts
478e5a5
@Owais28
updated License and babel configuration #7
29afabd
@Owais28
Merge branch 'master' of https://github.com/Owais28/TypeScript
70fbbfc
@Owais28
done #7
c0891ac
@Owais28
fixed tsconfig.json #7
3d907c0 
- removed extra unused configurations
@Owais28
removed one dependency #7
236f0b1
@Owais28
updated package.json #7
ff88b6f
@Owais28
updated QuickSelect.ts #7
282c457
@Owais28
algorithm : Added a Maths' Function as Abs.ts #10
17b48fd
@Owais28
Added Area.ts #10
7d73c34
@Owais28
Revert "algorithm : Added a Maths' Function as Abs.ts #10"
e2ff7cd 
This reverts commit 17b48fd.
@Owais28
algorithm : BinaryConvert.ts added (#12)
4d6a279
@Owais28
algorithm : BinaryConvert.ts added (#10)
67f6bdd
@Owais28
Update .gitignore #7
52bc243
@Owais28
Update .gitignore
188bd3e
@Owais28
update package-lock.json and package.json (#7)
0a7b4ca
@Owais28
update package.json and package-lock.json (#12)
fa0e9db
@Owais28
Merge remote-tracking branch 'origin/algorithm'
d736707
@Owais28
update
980700f
@Owais28
add Abs.ts in Maths (#15)
bfee02c
@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 26, 2022
appgurueu
appgurueu requested changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should be a trivial change is cluttered with QuickSelect and tooling setup here.

@Owais28 Owais28 closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu requested changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Owais28 @appgurueu @Panquesito7