Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

algorithm: greatest common factor #63

Merged
merged 1 commit into from
Oct 20, 2022
Merged

algorithm: greatest common factor #63

merged 1 commit into from
Oct 20, 2022

Conversation

Psytew
Copy link
Contributor

@Psytew Psytew commented Oct 17, 2022

Another requested feature from #10

@Psytew
Copy link
Contributor Author

Psytew commented Oct 17, 2022

Above issues addressed.

@Psytew Psytew requested a review from appgurueu October 17, 2022 22:19
appgurueu
appgurueu requested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, please use either GCF or GCD consistently 😄

@Psytew
Copy link
Contributor Author

Psytew commented Oct 18, 2022

Updated for consistency.

@raklaptudirm raklaptudirm changed the title Feat: Added GCF algorithm: greatest common factor Oct 20, 2022
@raklaptudirm raklaptudirm merged commit 07b1404 into TheAlgorithms:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

@appgurueu appgurueu appgurueu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Psytew @appgurueu @raklaptudirm