Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bevy 0.15 #318

Merged
merged 4 commits into from
Jan 12, 2025
Merged

Update to bevy 0.15 #318

merged 4 commits into from
Jan 12, 2025

Conversation

benfrankel
Copy link
Collaborator

@benfrankel benfrankel commented Oct 23, 2024

Fixes #320.

We'll probably want to set up a tag / versioning system soon.

The ChildBuild workaround I chose is probably not ideal, but it works.

Confirmed that the game compiles, runs, and seems fine.

@benfrankel benfrankel enabled auto-merge (squash) October 23, 2024 01:24
Copy link

@bas-ie bas-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked and working here! No idea what to say about the ChildBuild issue, but guess it doesn't block a merge?

@benfrankel benfrankel changed the title Update to bevy 0.15.0-rc.1 Update to bevy 0.15 Dec 1, 2024
@bas-ie
Copy link

bas-ie commented Dec 3, 2024

BTW I think the CI failure here is caused by dynamic_linking no longer working with cargo test --doc, have just been encountering this in another third-party crate.

@alec-deason
Copy link

alec-deason commented Dec 31, 2024

I think this error can be fixed by adding export LD_LIBRARY_PATH=`rustc --print target-libdir` or the equivalent to be CI job before cargo test runs.

@benfrankel
Copy link
Collaborator Author

benfrankel commented Jan 12, 2025

I can reproduce the CI failure on my own machine by running cargo test --doc. Running the same command on main also fails, so the failure seems to be unrelated to this PR.

This can also be seen with the same CI failure in #322, which only touches README.md.

EDIT: Upon further investigation, I see that the CI doctest failures started when the rustc toolchain changed from version 1.82.0 to 1.83.0. I also confirmed locally that either disabling the bevy/dynamic_linking feature OR prepending LD_LIBRARY_PATH="$(rustc --print target-libdir)" to the cargo test --doc command fixes the error.

This would be a silly reason to disable bevy/dynamic_linking, so I'm opting for the latter fix.

@benfrankel benfrankel disabled auto-merge January 12, 2025 23:01
@benfrankel benfrankel merged commit b97adac into TheBevyFlock:main Jan 12, 2025
4 checks passed
@benfrankel benfrankel deleted the update-deps branch January 12, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to bevy 0.15
3 participants