Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve release.yaml workflow #39

Merged
merged 7 commits into from
Jul 6, 2024

Conversation

benfrankel
Copy link
Collaborator

@benfrankel benfrankel commented Jul 6, 2024

Relevant to #19.

Overview of changes:

  • Trigger release on pushed tag starting with vA.B.C instead of any tag.
  • Fix "prepare package" step of web release job (copy from the wasm-release folder instead of release).
  • Set correct project and itch.io names.
  • Add wasm-opt step for web release.
  • Add name field to every step.
  • Pull duplicate values into local env variables.
  • Add helpful comments.
  • Clean up formatting, names, wording, etc.

Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a few notes, but nothing major. I think in the future this can be converted to a matrix due to the amount of duplicated code, but that's probably for a follow-up PR :)

.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@MiniaczQ
Copy link
Collaborator

MiniaczQ commented Jul 6, 2024

Jan mentioned earlier that if we modify the base CI template we should submit the changes to the upstream, I think I agree with that

@benfrankel
Copy link
Collaborator Author

benfrankel commented Jul 6, 2024

Jan mentioned earlier that if we modify the base CI template we should submit the changes to the upstream, I think I agree with that

Yeah that's probably true. Noting that their env variables and cargo build commands will be a bit different.

@benfrankel benfrankel requested review from MiniaczQ and BD103 July 6, 2024 16:34
Copy link
Collaborator

@MiniaczQ MiniaczQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, best way to test it would be to run it 😉

@benfrankel benfrankel merged commit da137ae into TheBevyFlock:main Jul 6, 2024
3 checks passed
@benfrankel benfrankel deleted the release-workflow branch July 6, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants