-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve release.yaml
workflow
#39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have a few notes, but nothing major. I think in the future this can be converted to a matrix due to the amount of duplicated code, but that's probably for a follow-up PR :)
Jan mentioned earlier that if we modify the base CI template we should submit the changes to the upstream, I think I agree with that |
Co-authored-by: BD103 <[email protected]>
Co-authored-by: BD103 <[email protected]>
Yeah that's probably true. Noting that their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, best way to test it would be to run it 😉
Relevant to #19.
Overview of changes:
vA.B.C
instead of any tag.wasm-release
folder instead ofrelease
).wasm-opt
step for web release.name
field to every step.env
variables.