-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G3 134: The geneweaver.core enumerations should use builtin IntEnum and StrEnum #4
G3 134: The geneweaver.core enumerations should use builtin IntEnum and StrEnum #4
Conversation
Test Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking, are existing unit test cases covering these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have anything to check that these are IntEnums, but we have existing unit tests that use these enums.
@francastell, I added a test to verify that the IntEnum classes are in fact IntEnum classes. |
Switching to IntEnum for Integer based enum definitions to allow usage in FastAPI type annotations.