Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not index sample programs that do not correspond to a valid project #69

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

rzuckerm
Copy link
Contributor

@rzuckerm rzuckerm commented Oct 3, 2024

I fixed #68 . I chose to just ignore a bad sample program name and move on as opposed to crashing. There will be an error in the log:

Could not find a project for <file_name> with name <url> in <project_names>

Also, updated the GitHub actions to fix this warning, for example:
test (3.11)

The following actions uses node12 which is deprecated and will be forced to run on node16: 
actions/checkout@v2, actions/setup-python@v2.

@rzuckerm rzuckerm added the bug Something isn't working label Oct 3, 2024
@rzuckerm rzuckerm requested a review from jrg94 October 3, 2024 22:58
@rzuckerm rzuckerm marked this pull request as ready for review October 3, 2024 23:03
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! You're quick.

@jrg94 jrg94 self-assigned this Oct 4, 2024
@jrg94 jrg94 merged commit 5dd2165 into TheRenegadeCoder:main Oct 4, 2024
5 checks passed
@rzuckerm rzuckerm deleted the no-bad-index branch October 4, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid sample program names should not be indexed
2 participants