Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1105 in utils.py #1114

Open
wants to merge 1 commit into
base: 2.18-Beta
Choose a base branch
from

Conversation

virophagesp
Copy link

@virophagesp virophagesp commented May 5, 2024

added import for shutil

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Proposed Changes

  • import shutil in utils.py

Why is this change needed?

It's needed because its allows beta to run on unix

Checklist:

  • My code follows the style guidelines of this project and I have read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

added import for shutil
@virophagesp
Copy link
Author

Ready to merge @ThioJoe
since this is literally 1 line added

@virophagesp
Copy link
Author

@ThioJoe

@@ -5,6 +5,7 @@
import Scripts.auth as auth
from googleapiclient.errors import HttpError
from html import unescape
import shutil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is ONE LINE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you suggest adding more lines to fix the issue?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you suggest adding more lines to fix the issue?

I tried this myself, and it does fix the issue. However, if you have other ideas or improvements, I'm happy to discuss them.

@therealOri
Copy link

Additional note;
logging.py also needs to be updated to import shutil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants