Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tiledb main branch to CI matrix #697

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sgillies
Copy link
Collaborator

@sgillies sgillies commented Jan 23, 2025

With this PR, we now test tiledb-cloud against 1) the minimum supported version of tiledb(-py), 2) the most recent supported release on PyPI, and 3) the main branch of the tiledb-py project.

In the first case, we pip install tiledb==0.30 and, after, pip install .[tests] determines that 0.30.0 meets the requirements and uses it.

In the second case, we pip install tiledb, get 0.33.2, and then pip install .[tests] determines that 0.33.2 is excluded, and then replaces it with a new install of 0.33.0 from PyPI.

In the third case, we install tiledb-py's main branch from GitHub, and pip install .[tests] determines that it meets the requirements.

The current test failures are due to timeouts on the server side. I'll rerun and they'll pass.

@sgillies sgillies self-assigned this Jan 23, 2025
@sgillies sgillies marked this pull request as ready for review January 23, 2025 20:33
@@ -37,6 +37,7 @@ jobs:
run: pre-commit run -a -v

run-tests:
name: "${{ matrix.tiledb-version-spec }}:${{ matrix.python-version }}:${{ matrix.dependencies }}:${{ matrix.os }}"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that the tiledb version appears first in the limited width left sidebar on, for example, https://github.com/TileDB-Inc/TileDB-Cloud-Py/actions/runs/12937321533.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant