Skip to content

Commit

Permalink
chore: address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
zepfred committed Aug 9, 2024
1 parent e067422 commit 84f51c8
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 26 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/pull_request_gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,11 @@ jobs:
java-version: [ 17 ] # Only the first supported LTS; already too many jobs here.
timeout-minutes: 120
steps:
# Clone timefold-quickstarts
# No need to check for stale repo, as Github merges the main repo into the fork automatically.
- name: Checkout timefold-quickstarts
uses: actions/checkout@v4
with:
path: './timefold-quickstarts'

# Clone timefold-solver
# Need to check for stale repo, since Github is not aware of the build chain and therefore doesn't automate it.
- name: Checkout timefold-solver (PR) # Checkout the PR branch first, if it exists
if: github.head_ref # Only true if this is a PR.
id: checkout-solver-pr
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/pull_request_maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,11 @@ jobs:
java-version: [ 17, 21, 22 ] #Latest two LTS + latest non-LTS.
timeout-minutes: 120
steps:
# Clone timefold-quickstarts
# No need to check for stale repo, as Github merges the main repo into the fork automatically.
- name: Checkout timefold-quickstarts
uses: actions/checkout@v4
with:
path: './timefold-quickstarts'

# Clone timefold-solver
# Need to check for stale repo, since Github is not aware of the build chain and therefore doesn't automate it.
- name: Checkout timefold-solver (PR) # Checkout the PR branch first, if it exists
if: github.head_ref # Only true if this is a PR.
id: checkout-solver-pr
Expand Down
14 changes: 0 additions & 14 deletions .github/workflows/pull_request_maven_long_running.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,11 @@ jobs:
java-version: [ 17 ] # Only the first supported LTS; already too many jobs here.
timeout-minutes: 120
steps:
# Clone timefold-quickstarts
# No need to check for stale repo, as Github merges the main repo into the fork automatically.
- name: Checkout timefold-quickstarts
uses: actions/checkout@v4
with:
path: './timefold-quickstarts'

# Clone timefold-solver
# Need to check for stale repo, since Github is not aware of the build chain and therefore doesn't automate it.
- name: Checkout timefold-solver (PR) # Checkout the PR branch first, if it exists
id: checkout-solver
uses: actions/checkout@v4
Expand Down Expand Up @@ -125,15 +121,11 @@ jobs:
java-version: [ 17 ] # Only the first supported LTS; already too many jobs here.
timeout-minutes: 120
steps:
# Clone timefold-quickstarts
# No need to check for stale repo, as Github merges the main repo into the fork automatically.
- name: Checkout timefold-quickstarts
uses: actions/checkout@v4
with:
path: './timefold-quickstarts'

# Clone timefold-solver
# Need to check for stale repo, since Github is not aware of the build chain and therefore doesn't automate it.
- name: Checkout timefold-solver (PR) # Checkout the PR branch first, if it exists
id: checkout-solver
uses: actions/checkout@v4
Expand All @@ -152,8 +144,6 @@ jobs:
path: ./timefold-solver
fetch-depth: 0 # Otherwise merge will fail on account of not having history.

# Clone timefold-solver-enterprise
# Need to check for stale repo, since Github is not aware of the build chain and therefore doesn't automate it.
- name: Checkout timefold-solver-enterprise (PR) # Checkout the PR branch first, if it exists
id: checkout-solver-enterprise
uses: actions/checkout@v4
Expand Down Expand Up @@ -208,15 +198,11 @@ jobs:
java-version: [ 17 ] # Only the first supported LTS; already too many jobs here.
timeout-minutes: 120
steps:
# Clone timefold-quickstarts
# No need to check for stale repo, as Github merges the main repo into the fork automatically.
- name: Checkout timefold-quickstarts
uses: actions/checkout@v4
with:
path: './timefold-quickstarts'

# Clone timefold-solver
# Need to check for stale repo, since Github is not aware of the build chain and therefore doesn't automate it.
- name: Checkout timefold-solver (PR) # Checkout the PR branch first, if it exists
id: checkout-solver
uses: actions/checkout@v4
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/pull_request_python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,11 @@ jobs:
python-version: ['3.11', '3.12']
timeout-minutes: 120
steps:
# Clone timefold-quickstarts
# No need to check for stale repo, as Github merges the main repo into the fork automatically.
- name: Checkout timefold-quickstarts
uses: actions/checkout@v4
with:
path: './timefold-quickstarts'

# Clone timefold-solver
# Need to check for stale repo, since Github is not aware of the build chain and therefore doesn't automate it.
- name: Checkout timefold-solver (PR) # Checkout the PR branch first, if it exists
if: github.head_ref # Only true if this is a PR.
id: checkout-solver-pr
Expand Down

0 comments on commit 84f51c8

Please sign in to comment.