Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: employee scheduling: put availabilities on employee #474

Merged
merged 2 commits into from
Jun 18, 2024
Merged

chore: employee scheduling: put availabilities on employee #474

merged 2 commits into from
Jun 18, 2024

Conversation

ge0ffrey
Copy link
Contributor

One issue left:

tests/test_feasible.py can't seem to find a feasible solution

@ge0ffrey ge0ffrey marked this pull request as ready for review June 18, 2024 19:14
Christopher-Chianelli
Christopher-Chianelli reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Java and Python locally, LGTM;

The Python API for Employee can be made nicer using default_factory, but I can do that in a separate PR

python/employee-scheduling/tests/test_constraints.py Show resolved Hide resolved
@Christopher-Chianelli Christopher-Chianelli merged commit 6238ea1 into TimefoldAI:development Jun 18, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christopher-Chianelli Christopher-Chianelli Christopher-Chianelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ge0ffrey @Christopher-Chianelli