Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor fairness in Tournament Scheduling #496

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jun 27, 2024

Description of the change

Brings the codebase in line with the new fairness support introduced in TimefoldAI/timefold-solver#918.

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

@triceo triceo force-pushed the fairness2 branch 2 times, most recently from 56cd0bf to 18bdd91 Compare June 27, 2024 10:09
@triceo triceo requested a review from zepfred June 27, 2024 10:16
@triceo triceo marked this pull request as ready for review July 1, 2024 05:37
@triceo triceo merged commit 629f2ca into TimefoldAI:development Jul 8, 2024
32 checks passed
@triceo triceo deleted the fairness2 branch July 8, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants