Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to ubuntu 22.04 in actions, rename to miniforge in docker action and require setuptools #446

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lauramurgatroyd
Copy link
Member

@lauramurgatroyd lauramurgatroyd commented Dec 18, 2024

Describe your changes

Describe any testing you have performed

Consider adding example code to examples

Link relevant issues

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the CIL developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'waiting for review'

Contribution Notes

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CILViewer (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

Qt contributions should follow Qt naming conventions i.e. camelCase method names.

VTK contributions should follow VTK naming conventions i.e. PascalCase method names.

@lauramurgatroyd lauramurgatroyd marked this pull request as ready for review December 18, 2024 16:35
@lauramurgatroyd lauramurgatroyd changed the title revert to ubuntu 22.04 revert to ubuntu 22.04 in conda action Dec 18, 2024
@lauramurgatroyd lauramurgatroyd marked this pull request as draft January 8, 2025 14:58
@lauramurgatroyd lauramurgatroyd changed the title revert to ubuntu 22.04 in conda action revert to ubuntu 22.04 in actions and rename to miniforge in docker action Jan 8, 2025
@lauramurgatroyd lauramurgatroyd marked this pull request as ready for review January 8, 2025 15:19
@lauramurgatroyd lauramurgatroyd changed the title revert to ubuntu 22.04 in actions and rename to miniforge in docker action revert to ubuntu 22.04 in actions, rename to miniforge in docker action and require setuptools Jan 9, 2025
@lauramurgatroyd lauramurgatroyd marked this pull request as draft January 9, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant