Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More JUCE suggestions #61

Merged
merged 2 commits into from
Oct 31, 2024
Merged

More JUCE suggestions #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6c9ee1
Silence warning when building with clang on Windows
Anthony-Nicholls Oct 30, 2024
62aaaa8
Fix arm64ec compilation issue
Anthony-Nicholls Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions containers/choc_Value.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2442,6 +2442,12 @@ void ValueView::serialise (OutputStream& output) const
uint8_t* localCopy = nullptr;

#if _MSC_VER

#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wlanguage-extension-token"
#endif

__try
{
localCopy = (uint8_t*) _alloca (dataSize);
Expand All @@ -2450,6 +2456,11 @@ void ValueView::serialise (OutputStream& output) const
{
throwError ("Stack overflow");
}

#ifdef __clang__
#pragma clang diagnostic pop
#endif

#else
localCopy = (uint8_t*) alloca (dataSize);
#endif
Expand Down
2 changes: 1 addition & 1 deletion math/choc_MathHelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#pragma intrinsic (_BitScanReverse64)
#endif

#ifdef _M_X64
#if defined (_M_X64) && ! defined (_M_ARM64EC)
#pragma intrinsic (_umul128)
#define CHOC_HAS_UMUL128 1
#endif
Expand Down