feat: notification component #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But notifications are not interactable beacuse of dialog backdrop?
Also implement request event similar to dialog. If the request event is prevented, card will not be closed.
Also refactor action slot test as it was always positive.
ogunb
force-pushed
the
141-notification-component
branch
from
2ecad4a to
bee906f
Compare
This change was prompted by issues encountered during the development of the component, where the native dialog element blocked any actions on it, event with Popover attribute. See more: https://github.com/Trendyol/baklava/issues/141\#issuecomment-1810301413 #141
|
@ogunb Good job!! 🚀 Just one thing, UI screenshots seem wrong on Chromatic, can we fix it? 🥲 
|
ogunb
force-pushed
the
141-notification-component
branch
from
3f5a530 to
0c2561b
Compare
They should be working now. |
ogunb
force-pushed
the
141-notification-component
branch
from
c9caa79 to
cd33f1a
Compare
Also improve notification object properties doc.
AykutSarac
reviewed
Nov 24, 2023
Co-authored-by: Aykut Saraç <[email protected]> Signed-off-by: Ogun Babacan <[email protected]>
ogunb
force-pushed
the
141-notification-component
branch
from
da7f9b6 to
cd22d6a
Compare
CagriAldemir
approved these changes
Nov 27, 2023
buseselvi
approved these changes
Nov 27, 2023
|
Thanks for the effort 🚀 LGTM! |
|
🎉 This PR is included in version 2.4.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141