New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

READY: Fixed win32 checkpoint resume SEGFAULT #8412

Open

qstokkink wants to merge 1 commit into Tribler:main from qstokkink:fix_32bitwin_save_path

+32 −2

Contributor

qstokkink commented Jan 24, 2025 •

edited

Loading

Fixes #8353

This PR:

Fixes a libtorrent SEGFAULT if resume_data does not include save_path on win32.

The new strategy is this:

Attempt to decode the existing resume_data, if this fails remove all the resume_data.
If we have valid resume_data and the save_path is not set, inject it based on the save_path of the ATP dict.

qstokkink force-pushed the fix_32bitwin_save_path branch 3 times, most recently from 66b95aa to b1ca0ff Compare

January 24, 2025 12:19


          Fixed win32 checkpoint resume SEGFAULT

4c7e23d

qstokkink force-pushed the fix_32bitwin_save_path branch from b1ca0ff to 4c7e23d Compare

January 24, 2025 12:25

qstokkink changed the title ~~WIP: Fixed win32 checkpoint resume SEGFAULT~~ READY: Fixed win32 checkpoint resume SEGFAULT

qstokkink marked this pull request as ready for review

January 24, 2025 12:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet