Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lines to the Dockerfile to import content types #33

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

carolyncaron
Copy link
Contributor

@carolyncaron carolyncaron commented Dec 6, 2023

Issue #32

Motivation

This PR is introducing the same fix to the dockerfile for importing content types as TripalCultivate/TripalCultivate-Phenotypes#56 did. This fix is needed since Tripal Core PR tripal/tripal#1696 was merged, and it changed the purpose of prepare and how content types were created. Note that the change in the phenotypes PR involving running trp-run-jobs was unnecessary for this module and thus has been left out of this PR.

What does this PR do?

  1. Adds drush commands to the dockerfile to import the General + Germplasm content type collections in core.
  2. Adds a cache rebuild command (drush cr) to the end of the Dockerfile since I know this will help in the future once a form for the Genotypes Loader is developed. Often, a cache rebuild is needed after install to have the form appear in the listing.

Testing

Manual Testing

See TripalCultivate/TripalCultivate-Phenotypes#56 for step-by-step instructions including screenshots.

Here are the specific commands I used for setting up my docker environment:

git clone https://github.com/TripalCultivate/TripalCultivate-Genetics.git trpcultivate-g0.32
cd trpcultivate-g0.32
git checkout g0.32-importContentTypes
docker build --tag=trpcultivate:G0.32 ./
docker run --publish=8080:80 --name=trpcultivate-G0.32 -tid --volume=`pwd`:/var/www/drupal/web/modules/contrib/TripalCultivate-Genetics trpcultivate:G0.32
docker exec trpcultivate-G0.32 service postgresql restart

Then I logged into the site and navigated to Admin > Tripal > Page Structure and confirmed that the expected content types were there.

I was also successfully able to create an organism through Admin > Tripal > Content > Add Tripal Content

Copy link
Member

@laceysanderson laceysanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the docker, ran a container and confirmed that all the categories of content types were now available! 🎉

Thanks @carolyncaron ❤️

@laceysanderson laceysanderson merged commit 848cf66 into 4.x Dec 7, 2023
5 checks passed
@laceysanderson laceysanderson deleted the g0.32-importContentTypes branch December 7, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants