This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Feat/button component #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bespokebob
suggested changes
Jan 21, 2019
src/styles/components/buttons.css
Outdated
| @@ -0,0 +1,198 @@ | |||
| @import '../../styles/variables.css'; | |||
|
|
|||
| button.ui.button.octagon{ | |||
There was a problem hiding this comment.
You are overriding parts of the SUI theme here, so this all needs to be part of the semantic-ui-theme overrides for the Button component. Otherwise, this is going to cause some very strange behavior by changing global button styles depending on if/when you import your new component.s
There was a problem hiding this comment.
@GirishSarbhukan @youngbob
Hi Bob,
I believe this is the last remaining item that needs to be resolved. I want to clarify what needs to be done so we can push this to completion.
- These styles should be in buttons.overrides instead of buttons.css.
- File imports should be adjusted as necessary.
- Style updates should be confined to Button
(e.g. line 213 '.visible.transition.disabled' is probably to global)
Bob, feel free to adjust this or add to this if needed.
There was a problem hiding this comment.
That sounds right to me.
bespokebob
reviewed
Jan 23, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated button components as per UX mock up:
Below are pending points#:
Dynamically passing items within Action menu.
..
UX Link for reference:
https://preview.uxpin.com/f5e0edd46a04128e1767b0cd57bdc2ddadcee475#/pages/100711315/simulate/sitemap