move defer out of loop so as not to leak a closure (#488)

* move defer out of loop so as not to leak a closure
* move handleSignals out of run loop because we never cancel it

core/app.go

@@ -97,10 +97,10 @@ func getEnvVarNameFromService(service string) string {
 
 // Run starts the application and blocks until finished
 func (a *App) Run() {
+	a.handleSignals()
 	for {
 		a.Bus = events.NewEventBus()
 		a.ControlServer.Run(a.Bus)
-		a.handleSignals()
 		a.handlePolling()
 		if !a.Bus.Wait() {
 			if a.StopTimeout > 0 {

events/timer.go

@@ -41,18 +41,18 @@ func NewEventTimer(
 ) {
 	go func() {
 		ticker := time.NewTicker(tick)
+		// sending the timeout event potentially races with a closing
+		// rx channel, so just recover from the panic and exit
+		defer func() {
+			if r := recover(); r != nil {
+				return
+			}
+		}()
 		for {
 			select {
 			case <-ctx.Done():
 				return
 			case <-ticker.C:
-				// sending the timeout event potentially races with a closing
-				// rx channel, so just recover from the panic and exit
-				defer func() {
-					if r := recover(); r != nil {
-						return
-					}
-				}()
 				rx <- Event{Code: TimerExpired, Source: name}
 			}
 		}