Improved Sentry server side error reporting #15866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErisDS
force-pushed
the
fix-sentry-unexpected
branch
from
49cea60 to
164c5d7
Compare
ErisDS
changed the title
Codecov ReportBase: 67.30% // Head: 67.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #15866 +/- ##
=======================================
Coverage 67.30% 67.30%
=======================================
Files 1625 1625
Lines 105999 106022 +23
Branches 14975 14981 +6
=======================================
+ Hits 71338 71357 +19
- Misses 33378 33384 +6
+ Partials 1283 1281 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ErisDS
force-pushed
the
fix-sentry-unexpected
branch
from
164c5d7 to
02cf824
Compare
- As demonstrated by my comments in the boot file, I thought sentry was already depending on the version package - IMO it's undesirable to require package.json directly esp when we have a tool setup and ready for tis - Added a bunch of tests to show that Sentry does roughly what we think
refs: https://github.com/TryGhost/Team/issues/1121 refs: TryGhost@5457402 - The previous change to fall back to a generic error on the server side is resulting in lots of much less useful Sentry reports - For unexpected errors, change what's sent to Sentry back to context - This is done by adding a specific code, so we don't have to match on a string that might change - Also add the error type, id, code & statusCode as tags to the events - these are searchable structured data - Adding code as a tag also makes it possible to find all errors that showed the generic message
ErisDS
force-pushed
the
fix-sentry-unexpected
branch
from
02cf824 to
3534099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: TryGhost/Team#2289
refs: TryGhost/express-hbs#161