Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Change headerbar dropdown menus #97

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Change headerbar dropdown menus #97

merged 1 commit into from
Oct 5, 2022

Conversation

TheEvilSkeleton
Copy link
Contributor

@TheEvilSkeleton TheEvilSkeleton commented Oct 5, 2022 •
edited
Loading

Licensing

  • I confirm that this is either my code or was released under the terms of a GPLv3-or-later compatible license. Also I agree to release it here under the terms of the GPLv3-or-later.

Description

This MR changes the icon of the dropdown menu to open-menu-symbolic, which is the standard for GNOME:

image

This also replaces "Settings" to "Preferences".

Ref. #95

@TheEvilSkeleton TheEvilSkeleton force-pushed the change-hamburger-menu-button branch from 2106934 to 44a65b7 Compare October 5, 2022 01:06
@TheEvilSkeleton TheEvilSkeleton changed the title Change hamburger menu button Change headerbar dropdown menus Oct 5, 2022
Schmiddiii
Schmiddiii approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@Schmiddiii Schmiddiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes are pretty sensible. Is there anything left you want to do here as it is still a Draft?

@TheEvilSkeleton
Copy link
Contributor Author

Yes, I kept it as draft because I want to sign commits. Apparently my laptop doesn't want to do it anymore so I'm committing from my PC now.

@TheEvilSkeleton TheEvilSkeleton force-pushed the change-hamburger-menu-button branch from 44a65b7 to 1d408be Compare October 5, 2022 13:39
@TheEvilSkeleton
Change headerbar dropdown menu button
cd85da5 
- Change arrow to `open-menu-symbolic`
- Change from "Settings" to "Preferences"
@TheEvilSkeleton TheEvilSkeleton force-pushed the change-hamburger-menu-button branch from 1d408be to cd85da5 Compare October 5, 2022 13:40
@TheEvilSkeleton TheEvilSkeleton marked this pull request as ready for review October 5, 2022 13:41
@Schmiddiii Schmiddiii merged commit bf2da9c into Tubefeeder:master Oct 5, 2022
@TheEvilSkeleton TheEvilSkeleton deleted the change-hamburger-menu-button branch October 5, 2022 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Schmiddiii Schmiddiii Schmiddiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheEvilSkeleton @Schmiddiii