Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo of PR 378 #407

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Redo of PR 378 #407

merged 4 commits into from
Nov 13, 2024

Conversation

Mahsaap
Copy link
Member

@Mahsaap Mahsaap commented Nov 13, 2024

Redo of #378 to remove extra commits becuase of switching from Master > Dev branch.
Added await to HandleWebException(s) to complete the PR changes required.

Error output supplemented by error from Twitch - Credit Neon-Sunset

Redo of 387 PR to remove extra commits from switching from Master to Dev branch.

- Add Twitch Error Response object.
add awaits to HandleWebException
@Mahsaap
Copy link
Member Author

Mahsaap commented Nov 13, 2024

Error output supplemented by error from Twitch

@Hampo
Copy link
Contributor

Hampo commented Nov 13, 2024

LGTM

Copy link
Member

@Syzuna Syzuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I guess.
In theory there is no need to have the custom exception types anymore but I think ppl might rely on them in catch filters so nothing to be done there for now

@Mahsaap Mahsaap merged commit 796c294 into TwitchLib:dev Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants