Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/14 website #437

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

feselene
Copy link

Hello World component working in localhost.

cd tpp-core\src\Website
dotnet run

Go to localhost in your browser and you will see the working hello world component.

image

image

@m4-used-rollout m4-used-rollout requested a review from Felk October 10, 2024 11:07
Copy link
Member

@Felk Felk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase your changes on the master branch without your refactorings please? It's hard to take a look at an individual thing if it's mixed in with lots of other changes.

Also, I'd like to know if you'd like to work on the website further after this change? Only some Hello World unfortunately isn't very useful. The interesting thing will be the migration path from the existing website.

@feselene
Copy link
Author

Could you rebase your changes on the master branch without your refactorings please? It's hard to take a look at an individual thing if it's mixed in with lots of other changes.

Also, I'd like to know if you'd like to work on the website further after this change? Only some Hello World unfortunately isn't very useful. The interesting thing will be the migration path from the existing website.

Of course, I'd be more than happy to implement Twitch integration and other features. I suggest we merge the refactorings PR before merging this PR, as I create the Website folder inside of the src folder.

@Felk
Copy link
Member

Felk commented Oct 11, 2024

Starting with twitch integration would be fantastic. Could you do this in this pull request before we merge anything please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants