-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/14 website #437
base: master
Are you sure you want to change the base?
Issue/14 website #437
Conversation
…lders into a src folder
…fully in localhost. Need to set up VM or dedicated server for twitchplayspokemon.tv URL to work.
…rfaces when running dotnet test
…ies are still using old file names
…me reason runtimes is in the path now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase your changes on the master branch without your refactorings please? It's hard to take a look at an individual thing if it's mixed in with lots of other changes.
Also, I'd like to know if you'd like to work on the website further after this change? Only some Hello World unfortunately isn't very useful. The interesting thing will be the migration path from the existing website.
Of course, I'd be more than happy to implement Twitch integration and other features. I suggest we merge the refactorings PR before merging this PR, as I create the Website folder inside of the src folder. |
Starting with twitch integration would be fantastic. Could you do this in this pull request before we merge anything please? |
Hello World component working in localhost.
cd tpp-core\src\Website
dotnet run
Go to localhost in your browser and you will see the working hello world component.