Refactor AUOWCache.Strategy to be a protocol #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😎 Merged successfully - details. |
aim2120
commented
Dec 18, 2024
aim2120
commented
Dec 18, 2024
|
This looks great! Thank you for the PR! I get where we'd hold off on the new cache strategy from being part of the sequence version of this, but should we make the same extensible refactor for the |
aim2120
force-pushed
the
share-from-cache-strategy-refactor
branch
from
d5c40df to
7f30874
Compare
Tyler-Keith-Thompson
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested in #164, this PR refactors
AUOWCache.Strategyto be a protocol that may be implemented by consumers. The refactor attempts to minimize the possibility of consumer breakage.