Review classification chapters #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 5, 2021 20:09
…more than 2 predictors sections with an example with 3 predictors, added explanation of set_engine, changed neighbours to american spelling
…ome paragraphs to clarify functions, removing unneeded explanations of functions which we will explain in earlier chapters, updating scaling/centering explanation, specifying data in balancing section
…doesn't go off page
…kap from output, explaining confusion matrix
| > **Note:** we set the seed when we call `train` not only because of the potential for ties, but also because we are doing | ||
| > cross-validation. Cross-validation uses a random process to select how to partition the training data. | ||
| > **Note:** we set the seed because we are doing | ||
| > cross-validation, which uses a random process to select how to partition the training data. |
There was a problem hiding this comment.
again, should be more careful about this note box
This was referenced Sep 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ttimbers @trevorcampbell PR for classification chapters review!
addressing issues: #106, #107, #92 and #93 (I either addressed it, added a rebuttal or made a new issue)
Also addressed these: #184, #228, #205