-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an index, style guide, handle remaining bugs #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nas for pdf output in inferencermd
trevorcampbell
changed the title
Create an index
Create an index, formatting/style guide
Sep 22, 2021
…n and wrangling first
Closed
Closed
Closed
leem44
reviewed
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trevorcampbell Thank you for putting all of this together!! Looks great!
- The page numbers in the index seem to be off by 2. E.g. "data science": in index says it's on page 5 but really its on page 7
- I guess we'll need to do another pass and look at all the plots and code that fall off page, and also the plots that are in weird places (e.g. in the middle of text etc)
- nice addition of the
set.seed
explanation! - a bunch of the figure references display "Figure ??" -- I started pointing them out and then realized that they are in a lot of places so likely this will need to be a part of the formatting pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not done yet.
I've finished everything listed below except the index (waiting for wrangling PR).
To address:
Index
I made one! This required some fixes to enable compile to PDF:
Fixes to make the book compile to PDF
out.width
pt
xelatex
handles unicode characters.img/population_vs_sample.svg
-- svgs break pdf outputxelatex
handles unicode characters.wilson2014best
)fig.retina = ...
ininference.Rmd
without actually settingout.width
(causes LaTeX to generatewidth=468px
which breaksxelatex
because the unit should bept
@online
entries inreferences.bib
to be@misc
This work closes #120
Style Guide
I created one. It's in README.md. I just made executive decisions on everything in the interest of moving this along, but feel free to raise anything I did there as a discussion item. Also feel free to move the style guide into its own
.md
file and link fromREADME.md
if desired.The work on the style guide closes #240 -- but note that we still need to do the actual formatting pass to fix it to conform to the style.
Clustering
Fixed the two examples of "failures" in clustering (bad init, bump in elbow plot).
This closes #236
Videos in chapter 2
No-op. These videos were removed (I assume it was the jupyter one). The only videos left are in the additional resources at the end, and those aren't about previewing data in jupyter. The jupyter chapter no longer has any videos.
I've added to the style guide a mention of making sure video links are usable in both pdf and html.
This work closes #189
Database in Chapter 2
Made it clearer that the DB host/username/password info that we use in ch2 is fake. This closes #187
Feedback on multicollinearity
agree, done
Nope - I don't think we should go into it in this text. I don't think it's possible to convey it in such a way that it won't cause students to go "oh well I don't like this datapoint, it looks wrong to me" and then just arbitrarily throw out data.
I agree, unstable is a bit too technical -- replaced with "unreliable" + explanation instead!
Definitely out of scope. I just point the reader to the end of the chapter.
See above.
agreed, but not worth the effort before CRC subm
This work closes #195
Feedback on predictor design
agree, done
I don't think we need to -- the plot axes are clear that we're plotting z now
I don't see any reason to - lowercase seems fine
it was defined in the text, but I added a quick printout of df at the beginning
I agree, but not worth the effort prior to CRC subm.
This work closes #196
set.seed
This work closes #168
Miscellaneous
faithful_plot.*
images toimg/
foldersmall_sacramento
) in regression1 (there was a point lying basically right on top of the dashed line)