-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to CKEditor #453
Switch to CKEditor #453
Conversation
fixed inline display + new apc line
… find builder area
It just occurred to me that the html for existing footnotes won't be compatible with the new footnotes style. We'll need to write a migration to convert them. |
The introduction on WorkForm and BookForm needs to have the editor enabled. |
Public commentary inline edit form needs to have its editor enabled |
Commentary apparatus criticus mentions aren't working |
src/rard/research/views/fragment.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplicate_fragment view function is massive. Most of the logic should probably be split out into utils and possible divided into a few smaller functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have opened #455 to address this in a later PR as another PR currently updates the logic
do they not use the IntroductionFormBase? Do I also need to enable it on the AntiquarianCreateForm as well? |
frrant/src/rard/research/forms.py Line 702 in 7c753c7
is this in the wrong place? |
Apparently not - it's the form you get when you create a new work or book as opposed to editing them once they're created. And yes looks like AntiquarianCreateForm also needs it. |
Pushed a fix: I think the problem was it was inside an if block that didn't always get executed. Copied the approach used for CommentaryFormBase instead. |
The create forms for Works and Antiquarians ( |
closes #423 and #452
related to #433 , may have resolved it since it caches now
Trying CKEditor as a fix for Quill's broken mention plugin (plus the weird pasting behaviour too hopefully)