Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEL-189-Create-lap-table-component #153

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

ZainabM872
Copy link
Contributor

Create a function to format the column headers

@ZainabM872 ZainabM872 requested a review from a team as a code owner October 30, 2024 00:00
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helios-telemetry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2024 6:34pm

Copy link
Collaborator

@justin-phxm justin-phxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Zainab! I like how clean and organized you have written the code. There are just a few changes that I think would make the code more maintainable.

packages/client/src/components/tabs/RaceTab.tsx Outdated Show resolved Hide resolved
packages/client/src/components/tabs/RaceTab.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/client/src/components/tabs/RaceTab.tsx Outdated Show resolved Hide resolved
packages/client/src/components/tabs/RaceTab.tsx Outdated Show resolved Hide resolved
@burtonjong
Copy link
Member

burtonjong commented Nov 2, 2024

@justin-phxm Brain suggested using tanstack table for this. Although, adding a package just for one feature doesn't seem super necessary unless maybe on the analysis tab you might be able to generate some stats that would be fit to put into a table? It wouldn't be a super big change either nor take very long

LMK

@justin-phxm
Copy link
Collaborator

@justin-phxm Brain suggested using tanstack table for this. Although, adding a package just for one feature doesn't seem super necessary unless maybe on the analysis tab you might be able to generate some stats that would be fit to put into a table? It wouldn't be a super big change either nor take very long

LMK

I'm not opposed to using a library for this, managing a table can get pretty complex especially with sorting filtering, etc.

@ideen1 ideen1 force-pushed the main branch 3 times, most recently from e6a0207 to a41ac25 Compare November 23, 2024 19:25
Copy link
Member

@David-Rodriguez-Barrios David-Rodriguez-Barrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burtonjong burtonjong merged commit 78c3e84 into main Dec 7, 2024
5 checks passed
@burtonjong burtonjong deleted the TEL-189-Create-lap-table-component branch December 7, 2024 18:46
David-Rodriguez-Barrios pushed a commit that referenced this pull request Dec 18, 2024
* table for lap data and lap tab

* moved code to RaceTab.tsx and deleted LapTab.tsx

* overhaul to tanstack table

---------

Co-authored-by: burtonjong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants