-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEL-189-Create-lap-table-component #153
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Zainab! I like how clean and organized you have written the code. There are just a few changes that I think would make the code more maintainable.
@justin-phxm Brain suggested using tanstack table for this. Although, adding a package just for one feature doesn't seem super necessary unless maybe on the analysis tab you might be able to generate some stats that would be fit to put into a table? It wouldn't be a super big change either nor take very long LMK |
I'm not opposed to using a library for this, managing a table can get pretty complex especially with sorting filtering, etc. |
e6a0207
to
a41ac25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* table for lap data and lap tab * moved code to RaceTab.tsx and deleted LapTab.tsx * overhaul to tanstack table --------- Co-authored-by: burtonjong <[email protected]>
Create a function to format the column headers