Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

car parts blink red, or orange #57

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

JenniferJa
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helios-telemetry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 2:23am

@ideen1
Copy link
Member

ideen1 commented Jan 30, 2024

Remember to rebase this change on top of main before submitting 💯

alexwhelan12
alexwhelan12 previously approved these changes Feb 3, 2024
Copy link
Contributor

@alexwhelan12 alexwhelan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@CalebBourb CalebBourb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need blank lines at the end of your files for best practices

Copy link
Contributor

@IshaHaider IshaHaider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed. Looks good!

Copy link
Contributor

@IshaHaider IshaHaider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-ngyn brian-ngyn requested review from CalebBourb and removed request for CalebBourb February 13, 2024 02:37
@ideen1 ideen1 merged commit 4d73472 into main Feb 13, 2024
4 checks passed
David-Rodriguez-Barrios pushed a commit that referenced this pull request Dec 18, 2024
* Add textures to car graphic

* Added basic stuff for car indication flashing

Co-authored-by: JenniferJa <[email protected]>

---------

Co-authored-by: ideen1 <[email protected]>
Co-authored-by: JenniferJa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants