Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pis layout work #62

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Pis layout work #62

merged 5 commits into from
Feb 13, 2024

Conversation

justin-phxm
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helios-telemetry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 3:37am

Copy link
Member

@ideen1 ideen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the styling look identical to what is currently on main

app/src/renderer/code/App.tsx Outdated Show resolved Hide resolved
app/src/renderer/code/App.tsx Outdated Show resolved Hide resolved
app/src/renderer/code/components/atoms/FaultCard.tsx Outdated Show resolved Hide resolved
app/.eslintrc.cjs Outdated Show resolved Hide resolved
app/src/renderer/public/models/Duck.gltf Outdated Show resolved Hide resolved
@justin-phxm justin-phxm removed their assignment Feb 13, 2024
@ideen1 ideen1 dismissed IshaHaider’s stale review February 13, 2024 03:43

We resolved these changes

@ideen1 ideen1 merged commit dcd5c61 into main Feb 13, 2024
4 checks passed
@ideen1 ideen1 deleted the PIS-layout-work branch February 13, 2024 03:43
David-Rodriguez-Barrios pushed a commit that referenced this pull request Dec 18, 2024
* Pis boolean fixes

* made fault tab display dynamically split columns

* Refactor component styling in PIStransformer.tsx

* Fix import statement in FaultsTab component

* fix merge and rebase erorrs

---------

Co-authored-by: ideen1 <[email protected]>
Co-authored-by: jenniferja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants