Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate post-MCT interaction term operations in iterative_lottery_choices #72

Merged
merged 3 commits into from
Sep 27, 2021

Conversation

mxndrwgrdnr
Copy link
Member

@mxndrwgrdnr mxndrwgrdnr commented Sep 13, 2021

Corresponds to #126 in urbansim_templates. Tests currently failing here because they're running against the un-updated urbansim_templates, where the bulk of the relevant changes have been made.

@github-actions
Copy link

Test coverage is 77%

Copy link
Member

@smmaurer smmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@smmaurer
Copy link
Member

This PR appends an optional parameter to choicemodels.tools.iterative_lottery_choices(). If the user passes a dictionary of mct_intx_ops, the requested post-processing operations will be performed each time a choice table is generated.

@smmaurer smmaurer merged commit b603239 into dev Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants