Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/cd: Github Action #16

Open
wants to merge 43 commits into
base: develop
Choose a base branch
from
Open

Ci/cd: Github Action #16

wants to merge 43 commits into from

Conversation

akshitbatra
Copy link
Collaborator

@akshitbatra akshitbatra commented May 31, 2023

Check added for now:

  1. Talisman Secret scanning
  2. test coverage check - threshold 80% - can be changed in package.json file

P.S: This branch doesn't have any tests, needed to remove as we made a lot of changes so they were failing.
Will update before merging

Pipeline is running on ci/cd branch, need to discuss to move it to main or develop.

Extra files:

  1. Dockerfile - contains script to run talisman locally
  2. detect-secrets - calls dockerfile and scans the codebase

./detect-secrets can be added to pre-commit hook to run talisman check on local in pre-commit hook.

Update:

pre-commit - Add eslint + typechecks

Netlify link: https://hatch-a-cab.netlify.app/cab-request

@akshitbatra akshitbatra changed the base branch from main to develop May 31, 2023 17:13
@akshitbatra akshitbatra temporarily deployed to prod July 11, 2023 12:44 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants