Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anaeriobic digestion proxy script #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ccoxen
Copy link
Collaborator

@ccoxen ccoxen commented Dec 19, 2024

Add anaeriobic digestion script to the proxy scripts to process the proxy file for anaerobic digesters



total_SCFM = 29877 - 1465 # 1,465 SCFM is from the farm digesters (all have missing lat/long data), which we need to substract from the total in order to get accurate proportions for the WRRF and stand-alone digesters
WRRF = 23587 / total_SCFM # 23,587 SCFM is from WRRF
Copy link
Collaborator

@nkruskamp nkruskamp Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these values fixed by facility type? The code below looks to do the the allocation of inventory emissions to the facilities and then normalizes those. In this case think that allocation step isn't necessary, we just normalize the fixed values by facility type. I may be missing something here. Let's talk it through.

# %% Read in the data

# Read in emi data
anaerobic_digestion_emi = pd.read_csv(emi_data_dir_path / "anaerobic_digestion_emi.csv")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wrap the entirety of the inputs files and output proxy file into a function so it is clear which files are being used. For the emi file see the other comment on if we need it here or not since allocation happens in the next step.

Copy link
Collaborator

@nkruskamp nkruskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chris, looking good. My question is if we have fixed values from the biogas report, I think those should be assigned and normalized by facility type, and we don't need to use the emissions inventory values here, since the allocation by relative amount happens in the next step.

Can we wrap everything into a single function so that it's clear the full list of input and output files for this proxy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants