natural gas pipelines proxies #33
Conversation
| V3_DATA_PATH | ||
| ) | ||
|
|
||
| lower_48_and_DC = ('AL', 'AR', 'AZ', 'CA', 'CO', 'CT', 'DE', 'FL', 'GA', 'IA', 'ID', 'IL', |
There was a problem hiding this comment.
Can we grab the keys from the us_state_to_abbrev_dict in utils.py for this list?
| if verbose: print('loading state and pipeline data') | ||
|
|
||
| # Load state geometries and pipeline data (keeping existing code) | ||
| state_shapes = gpd.read_file(V3_DATA_PATH / 'geospatial/cb_2018_us_state_500k/cb_2018_us_state_500k.shp') |
There was a problem hiding this comment.
Can you move this path into the function parameters so it is clear this file is being used in the proxy creation?
| us_state_to_abbrev_dict | ||
| ) | ||
|
|
||
| lower_48_and_DC = ('AL', 'AR', 'AZ', 'CA', 'CO', 'CT', 'DE', 'FL', 'GA', 'IA', 'ID', 'IL', |
There was a problem hiding this comment.
Can use values from us_state_to_abbrev_dict in utils.py for this?
| ############################################################### | ||
|
|
||
| # load state geometries for continental US | ||
| state_shapes = gpd.read_file(V3_DATA_PATH / 'geospatial/cb_2018_us_state_500k/cb_2018_us_state_500k.shp') |
There was a problem hiding this comment.
Please move this path into the parameters for the function so we can see it is being used.
| @@ -0,0 +1,208 @@ | |||
| #%% | |||
There was a problem hiding this comment.
Do you want to add the header here before it goes to main?
| @@ -0,0 +1,98 @@ | |||
| #%% | |||
There was a problem hiding this comment.
Do you want to add a header here before it goes to main?
| croplands_path_template: Path = sector_data_dir_path / "nass_cdl/{year}_30m_cdls_all_crop_binary.tif", | ||
|
|
||
| #Outputs | ||
| output_path: Annotated[Path, Product] = proxy_data_dir_path / "farms_pipeline_proxy.parquet" |
There was a problem hiding this comment.
remove s from farms -> farm_pipelines_proxy I've already changed the actual file name.
|
|
||
| #Outputs | ||
| output_path: Annotated[Path, Product] = ( | ||
| proxy_data_dir_path / "trans_pipeline_proxy.parquet" |
There was a problem hiding this comment.
ADD "s" to pipelines -> trans_pipelines_proxy. I've changed the file name already.
This PR completes tasks:
trans_pipelines_proxy
farms_pipelines_proxy