Fix option c #135 #195
Merged
Fix option c #135 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run autoclean and check required fields when data is uploaded in Option C on import tab
run autoclean, include placeholder for user message regarding required cols
cristinamullin
commented
Dec 17, 2024
| # check that all TADA template columns are included (returns TRUE or FALSE) | ||
| # if FALSE, returns an error with names of specific columns that are missing but required | ||
| # this section needs to be updated to handle the error within the shiny app (instead of crashing) & display a message to users | ||
| EPATADA::TADA_CheckRequiredFields(raw) |
There was a problem hiding this comment.
@triphook I am working on related updates to the TADA package, but once those are merged and this PR is merged, then this will be a good example to look at for implementing error handling in TADAShiny.
Here, when TADA_CheckRequiredFields runs on a dataset that is uploaded by a user (option C), but that dataset is missing required cols to run the app, then TADA_CheckRequiredFields will intentionally return an error which includes the missing cols. Instead of crashing the shiny app, this message should display for users and they should be able to edit their file and re-upload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.