Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching indicator in autocomplete #125

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

TyHil
Copy link
Member

@TyHil TyHil commented Nov 2, 2023

Resolves #117

The loading text is only renders when loading is true and there are no options in Autocomplete so it only shows up on the first character. But I think that's good.

@TyHil TyHil requested a review from iamwood as a code owner November 2, 2023 19:30
@TyHil TyHil linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
utd-trends ✅ Ready (Inspect) Visit Preview Nov 2, 2023 7:30pm

@TyHil TyHil changed the title Initial Searching indicator in autocomplete Nov 2, 2023
Copy link
Contributor

@Jake3231 Jake3231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The behavior works well, and the code changes seem fairly straightforward.

@TyHil TyHil merged commit 3f7a02a into develop Nov 15, 2023
2 checks passed
@TyHil TyHil deleted the feature/searching-indicator-in-autocomplete branch November 15, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Searching indicator in autocomplete
2 participants