Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add voronoi utility functions #1984

Closed
wants to merge 4 commits into from
Closed

Add voronoi utility functions #1984

wants to merge 4 commits into from

Conversation

casperlamboo
Copy link
Contributor

@casperlamboo casperlamboo commented Nov 20, 2023 •
edited
Loading

Description

This PR add several utilities to resolve the dreaded voronoi crashes. In this PR some debug utilities are added, this includes

  • Writing SVGs for VoronoiDiagrams
  • WKT writing/reading for the Polygon class

Unit tests, that test the complete WallsComputation.generateWalls walls.

CURA-11361
CURA-11362

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Utility functions

How Has This Been Tested?

Yes

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

@casperlamboo
Copy link
Contributor Author

superseded by #1988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@casperlamboo