Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-11392-including-threshold-setting-for-ppr #1996

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

saumyaj3
Copy link
Contributor

CURA-11392

for internal printers,
Introduce Threshold settings for Printjobs so it can be taken into account for print progress reporting

@rburema
Copy link
Member

rburema commented Dec 14, 2023

GCode-analyzer failing, probably because it has the wrong version of Cura checked out. Should go alright if we merge this after the Cura branch is merged.

@rburema rburema merged commit 1739945 into main Dec 14, 2023
19 of 20 checks passed
@rburema rburema deleted the CURA-11392-including-threshold-setting-for-ppr branch December 14, 2023 12:13
@jellespijker
Copy link
Member

Why is this in the engine?
This could be implemented in the front-end with the formula's in the start/end gcode

@rburema
Copy link
Member

rburema commented Dec 15, 2023

@jellespijker The rest of the Griffin-header is also done in the engine. If we want to do it that way, I'd propose moving it over wholesale.

    case EGCodeFlavor::GRIFFIN:
        prefix << ";START_OF_HEADER" << new_line_;
        prefix << ";HEADER_VERSION:0.1" << new_line_;
        prefix << ";FLAVOR:" << flavorToString(flavor_) << new_line_;
        prefix << ";GENERATOR.NAME:Cura_SteamEngine" << new_line_;
        prefix << ";GENERATOR.VERSION:" << CURA_ENGINE_VERSION << new_line_;
        prefix << ";GENERATOR.BUILD_DATE:" << Date::getDate().toStringDashed() << new_line_;
        prefix << ";TARGET_MACHINE.NAME:" << transliterate(machine_name_) << new_line_;

@jellespijker
Copy link
Member

yes, but these are also for a subset of printers that use the griffin header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants