fix: Use androidx.appcompat for better AlertDialog styling #93
Conversation
Remove unnecessary API dependency on Kotlin stdlib.
The user might register with a distributor, and then delete the distributor app. If that happens the user is not prompted if there are no distributors, and re-registration does not happen. Fix this by checking the ack'ed distributor is still in the list of installed distributors.
Previous code ignored the dialog's default layout and set its own textview. I think this was so a LinkMovementMethod could be set on the message. This meant the view didn't follow normal Android dialog dimensions (e.g., padding, margins, text layout), and looked out of place. Fix this. Use the normal AlertDialog message. Set an onShowListener that sets the LinkMovementMethod when the dialog is shown.
The strings used in default dialogs were hardcoded. This meant they couldn't be translated, or use the default platform strings (e.g., android.R.string.ok). Fix that. Convert `RegistrationDialogContent`, `NoDistributorDialog`, and `ChooseDialog` to interfaces, and provide implementations of those interfaces that
|
I think this is preferable to not update the minSdk |
|
Would you consider splitting this in to android-connector and android-connector-ui libraries, with the "...WithDialog" related functionality moving to the -ui library? Looking at the first and third screenshot in #87, the difference in visuals is pretty jarring, especially when this dialog might be one of the first bits of UI they see from an app that uses this library (assuming that apps try and register early in the startup process). |
|
You mean publishing a new library ? The purpose of this dialog is to provide a quick and dirty way to use the lib, but most app write their own way to pick a distributor. So I don't think it is worth losing 5 SDK versions |
Yes. The -ui library would have minSdk set to 21 to allow the use of androidx.appcompat, the existing library would stay at 16.
https://github.com/search?q=UnifiedPush+registerAppWithDialog&type=code has some false positives, but I'm not sure it supports the idea that "most apps write their own way". |
Bumps minSdk to 21.