Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CLI and Python packages #95

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Rename CLI and Python packages #95

merged 2 commits into from
Jan 9, 2025

Conversation

sgreenbury
Copy link
Contributor

Part of #77.

@sgreenbury sgreenbury force-pushed the 77-update-package-names branch from 6f70522 to e75913f Compare December 17, 2024 16:46
@sgreenbury
Copy link
Contributor Author

The current packages are now renamed as:

  • popgetter -> popgetter-core
  • popgetter_cli -> popgetter-cli
  • popgetter_py -> popgetter-py

One result of the rename is that none of the crates share the name of the project (i.e. popgetter). There are a few options if we'd like to have a popgetter crate:

  1. Revert popgetter-core to popgetter
  2. Change popgetter-cli to popgetter
  3. Create a workspace level crate re-exporting the member crates (possibly with features). This would lead to 4 crates: popgetter-core, popgetter-cli, popgetter-py, popgetter (workspace level)
  4. Create another member crate called popgetter providing with popgetter-core as a dep and providing a crate with the sole purpose of being a Rust library for popgetter (e.g. like the bindings packages: Python, npm etc)

I think (for now) it might make sense to retain flexibility and keep the renames as is but could consider implementing/changing to any the above options in the future.

@sgreenbury sgreenbury merged commit 3bc4e00 into main Jan 9, 2025
9 checks passed
@sgreenbury sgreenbury deleted the 77-update-package-names branch January 9, 2025 16:23
@sgreenbury
Copy link
Contributor Author

Merging this now following discussion with @andrewphilipsmith with a popgetter crate as a placeholder or providing docs pointing to the 3 popgetter crates planned in #77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants