media driver buffer sharing #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongbolv
reviewed
Oct 17, 2019
| { | ||
| usleep(10000); //sleep 10ms for the first frame | ||
| iframe++; | ||
| } |
There was a problem hiding this comment.
Please add comments here for just work around, will fix later.
hongbolv
reviewed
Oct 17, 2019
| PDDI_MEDIA_CONTEXT mediaCtx = DdiMedia_GetMediaContext(ctx); | ||
| DDI_CHK_NULL(mediaCtx, "nullptr mediaCtx", VA_STATUS_ERROR_INVALID_CONTEXT); | ||
|
|
||
| mediaCtx->bBltMode = false; |
There was a problem hiding this comment.
Please initialize the bBltMode in the context initialize stage.
hongbolv
reviewed
Oct 17, 2019
| { | ||
| DDI_CHK_NULL(attrib_list, "nullptr attrib_list", VA_STATUS_ERROR_INVALID_PARAMETER); | ||
| } | ||
|
|
hongbolv
reviewed
Oct 17, 2019
| VPHAL_RENDER_ASSERT(pRenderState->GetRenderHalInterface()); | ||
|
|
||
| pRenderer->pRender[VPHAL_RENDER_ID_VEBOX+pRenderer->uiCurrentChannel]->SetStatusReportParams(pRenderer, pRenderParams); | ||
|
|
There was a problem hiding this comment.
Which place to initialize the "uiCurrentChannel"? Suggest to use VPHAL_RENDER_ID_BLITTER to find the render instance.
hongbolv
reviewed
Oct 17, 2019
| @@ -413,6 +413,7 @@ typedef enum _MOS_GPU_CONTEXT | |||
| MOS_GPU_CONTEXT_COMPUTE = 14, //Compute Context | |||
| MOS_GPU_CONTEXT_CM_COMPUTE = 15, // MDF Compute | |||
| MOS_GPU_CONTEXT_MAX = 16, | |||
| MOS_GPU_CONTEXT_BLITTER = 17, | |||
There was a problem hiding this comment.
Please define the MOS_GPU_CONTEXT_BLITTER before MOS_GPU_CONTEXT_MAX.
|
Please align the the code layout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.