Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it more clear that SSID filter is case sensitive #442

Conversation

mx1up
Copy link
Contributor

@mx1up mx1up commented Dec 9, 2023

What does this implement/fix? Please describe.

  • adds "(case sensitive)" to the SSID filter title

Does this close any currently open issues?
fixes #441

Additional context

  • I guess this string might need translation now (currently it is marked as untranslatable), if so, please explain how your translation workflow works.

Where has this been tested?

  • Tested in emulator

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #442 (2a5d9fc) into feature (2f5f3ba) will not change coverage.
Report is 2 commits behind head on feature.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             feature     #442   +/-   ##
==========================================
  Coverage      92.85%   92.85%           
  Complexity       940      940           
==========================================
  Files            131      131           
  Lines           2743     2743           
  Branches         229      229           
==========================================
  Hits            2547     2547           
  Misses            59       59           
  Partials         137      137           

@VREMSoftwareDevelopment
Copy link
Owner

This would definitely require translation to other languages currently supported by the application.
There is no automatic translation workflow available in this project, if you know of any automatic translation you are welcome to implement it.

The other choice could be implementation of the universal icons (no translation required), ie:
gui-case-sensitive-svgrepo-com

@mx1up
Copy link
Contributor Author

mx1up commented Dec 10, 2023

ok, I will just update the translation files. For the languages that I do not know, should I provide an English stub in each language file or do I leave it out so there is fall back on the language agnostic strings.xml?
Or maybe I can use google translate as it is a quite short translation? (though maybe not easy for google translate to interpret correctly..)

As a translation workflow, Transifex comes to mind, which is free for open source projects. However, I don't have experience implementing it and as this project is as good as finished, the return on investment seems quite low.

@VREMSoftwareDevelopment
Copy link
Owner

Or maybe I can use google translate as it is a quite short translation? (though maybe not easy for google translate to interpret correctly..)

Probably Google Translate is good enough for now.

@mx1up
Copy link
Contributor Author

mx1up commented Dec 31, 2023

I have added translation, based on google translate and wikipedia. I also verified that longer strings don't pose a problem.

Is it okay to rebase?

@VREMSoftwareDevelopment
Copy link
Owner

Since there are not conflicts, rebase is not necessary.

@mx1up
Copy link
Contributor Author

mx1up commented Jan 1, 2024

Okay, so I guess I'm ready then..

@VREMSoftwareDevelopment
Copy link
Owner

Thank you for your contribution

@VREMSoftwareDevelopment VREMSoftwareDevelopment merged commit c1cd296 into VREMSoftwareDevelopment:feature Jan 13, 2024
3 checks passed
@mx1up
Copy link
Contributor Author

mx1up commented Jan 13, 2024

thanks for accepting 👍

Repository owner deleted a comment from Mangager Aug 19, 2024
Repository owner deleted a comment from Mangager Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants