Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monochrome icon #451

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Add monochrome icon #451

merged 1 commit into from
Jan 13, 2024

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Dec 26, 2023

The icon is same as foreground file with stroke colors set to black. The following screenshot shows how the monochrome icon looks in Android 13 (LineageOS 20).

image

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #451 (a7e7c60) into feature (4fdd956) will not change coverage.
Report is 6 commits behind head on feature.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             feature     #451   +/-   ##
==========================================
  Coverage      92.85%   92.85%           
  Complexity       940      940           
==========================================
  Files            131      131           
  Lines           2743     2743           
  Branches         229      229           
==========================================
  Hits            2547     2547           
  Misses            59       59           
  Partials         137      137           

@VREMSoftwareDevelopment
Copy link
Owner

Thank you for your contribution

@VREMSoftwareDevelopment VREMSoftwareDevelopment merged commit 91c1453 into VREMSoftwareDevelopment:feature Jan 13, 2024
3 checks passed
@Biswa96 Biswa96 deleted the add-monochrome-icon branch January 13, 2024 15:40
@Biswa96
Copy link
Contributor Author

Biswa96 commented Jan 13, 2024

Is it possible to upload the APK in the CI artifact, please?

@VREMSoftwareDevelopment
Copy link
Owner

Sorry, this project does not use Github CI workflows to created certified APK

@Biswa96
Copy link
Contributor Author

Biswa96 commented Jan 20, 2024

I meant debug builds which do not require to be signed.

@VREMSoftwareDevelopment
Copy link
Owner

@Biswa96
Currently there is no workflow that does it.
Would you like to create a new PR for this?
Otherwise you will have to wait until someone is available to implement this.

@VREMSoftwareDevelopment
Copy link
Owner

@Biswa96
Please note since the code in the development state, the APK may have bugs/issues.

@VREMSoftwareDevelopment
Copy link
Owner

VREMSoftwareDevelopment commented Jan 21, 2024

@Biswa96
Workflow with build/artifact debug beta APK
Commit: f42bf38
Workflow: https://github.com/VREMSoftwareDevelopment/WiFiAnalyzer/actions/runs/7603613923

@VREMSoftwareDevelopment VREMSoftwareDevelopment mentioned this pull request Feb 22, 2024
@saltsoftdrink
Copy link

@VREMSoftwareDevelopment are you working on this it's been stopped from a month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants