Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generic static This. #2533

Merged

Conversation

max-kahnt-keylight
Copy link
Contributor

Attempt to fix #2531.
Should probably be extended to be used in all static This inferences.

@1mike12
Copy link
Contributor

1mike12 commented Jul 22, 2024

i know this is a while ago, but can you give an example of what was broken before? Since this is not maintained anymore, I am ingesting all fixes into my fork. This seems similar to lots of other typescript fixes that were already proposed and merged into my fork. Woudl love to add your fix too

@max-kahnt-keylight
Copy link
Contributor Author

I am not sure what additional context to give apart from the issue #2531 that is already linked.
It seems like this fix is/was needed in order to have the changes from #2399 (which has been reverted).

@lehni
Copy link
Collaborator

lehni commented Sep 25, 2024

This looks reasonable. @max-kahnt-keylight could you follow up with another PR to use the same approach in all static this inferences?

@lehni lehni marked this pull request as ready for review September 25, 2024 11:21
@lehni lehni merged commit bf76780 into Vincit:main Sep 25, 2024
@max-kahnt-keylight
Copy link
Contributor Author

💚 Very much appreciated that you are getting back to this even though the issue currently doesn't haunt me personally.

I created #2700 now. I am not sure if I will be able to test it reasonably and push its finalization, but I think it definitely makes sense to have this in all such places 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type inferred is wrong when using model constructor
3 participants