-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: [1.20.4] Many API Additions #255
base: Multiloader-1.20.4
Are you sure you want to change the base?
Draft: [1.20.4] Many API Additions #255
Conversation
7c311a2
to
e8198a4
Compare
Rebased onto Unrelated, but if it makes life easier, I'm happy to rebase this after #284 is merged. |
e8198a4
to
ab8b5d1
Compare
This PR is now caught up with the big refactor, but is untested. That said, I've marked it as draft, as there's several changes I'd like to make, and because the catching up to the refactor is entirely untested beyond ensuring it builds. These changes include:
|
426b2fe
to
b8c7771
Compare
Squashed everything into one commit for now to make rebasing less annoying and now rebased on top of the JOML changes. Still need to test and make the changes above, but that should happen soon. |
fc4e468
to
83c153b
Compare
dea1552
to
241a39e
Compare
For those following this, the migration to |
e416d67
to
838c872
Compare
Marking this as ready for review. The test mod is updated at https://github.com/hammy275/mc-vr-playground/releases/tag/v2.1.0, which should allow testing the vast majority of the API's functionality. I'm looking for all forms of feedback imaginable, whether it's bugs, feedback on API-design (big or small), or anything else. There is definitely more I want to see added to the API, such as what's mentioned in #335, but this PR is already really big in-scope, so I'd rather get this merged so future, smaller API additions can be made separately than continue to delay this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked though, and added some notes
common/src/main/java/org/vivecraft/common/api_impl/data/VRPoseImpl.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/vivecraft/server/ServerVivePlayer.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/vivecraft/server/ServerVivePlayer.java
Outdated
Show resolved
Hide resolved
6bb5499
to
88e8924
Compare
The review as it was should be addressed at this point. Going to update MC VR Playground so some testing can be done on the PR since it hasn't been tested since the review was addressed and it currently doesn't cover any of |
A 1.20.4 port of #184 . This also adds a couple of new changes:
isVanillaRenderPass()
to the bottom of the file, since its still marked@Beta
. Perhaps we want to make aVivecraftRenderingAPI
or something, just for organization?isFirstRenderPass()
andgetCurrentRenderPass()
, as requested.All features can be tested with this test mod. Note that the test mod itself has only been tested on Fabric, but should work in Forge.