Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Date picker #237

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Add Date picker #237

merged 8 commits into from
Jan 20, 2025

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #236

@vitPinchuk vitPinchuk self-assigned this Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (60d2949) to head (b08c398).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   98.83%   98.84%   +0.01%     
==========================================
  Files          71       73       +2     
  Lines        1625     1650      +25     
  Branches      484      436      -48     
==========================================
+ Hits         1606     1631      +25     
- Misses         18       19       +1     
+ Partials        1        0       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jan 9, 2025
@mikhail-vl mikhail-vl added this to the Variable 3.7.0 milestone Jan 9, 2025
asimonok
asimonok requested changes Jan 9, 2025
View reviewed changes
src/types/panel.ts Outdated Show resolved Hide resolved
src/utils/format.test.ts Outdated Show resolved Hide resolved
src/components/DateSelector/DateSelector.tsx Outdated Show resolved Hide resolved
@vitPinchuk vitPinchuk requested a review from asimonok January 14, 2025 10:38
asimonok
asimonok approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 5e1c007 into main Jan 20, 2025
5 checks passed
@mikhail-vl mikhail-vl deleted the feat/date-picker branch January 20, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Variable 3.7.0
Development

Successfully merging this pull request may close these issues.

Add Date only selector
3 participants
@vitPinchuk @asimonok @mikhail-vl