Fix timeline "new year" bug #1412
Open
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded and deployed at https://prism-1412.surge.sh |
|
looks good from my side @ericboucher, thanks. Did you intend to keep the console logs? |
wadhwamatic
approved these changes
Jan 15, 2025
|
Just ran through the paces with seasonal CDI paired with various wms layers — all the logic worked well. Nice work @ericboucher |
gislawill
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #1411.
I made two small changes to fix the issue:
Unrelated, this PR also fixes a small bug in the Python API CI by fixing the Python version.
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: