Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on cljx-sampling #248

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Remove dependency on cljx-sampling #248

merged 3 commits into from
Oct 17, 2024

Conversation

nnichols
Copy link
Member

Proposed Changes

  • Added
    • Ingredient sampling functions brew-bot.sampling.api/sample and brew-bot.sampling.api/weighted-sample.
    • A macro brew-bot.sampling.api/with-seed to set a seed for the internal random generator over multiple sampling calls.
  • Removed
    • Dependency on cljx-sampling has been removed.

Pre-merge Checklist

  • Read and agree to the Contribution Guidelines and Code of Conduct
  • Write new tests for impacted functionality
  • Update the CHANGELOG and increment version
  • Update the README and other relevant documentation

@nnichols nnichols requested a review from a team as a code owner October 17, 2024 13:05
@nnichols nnichols requested review from Dareknotderek and removed request for a team October 17, 2024 13:05
@WallBrewBot WallBrewBot added documentation Improvements or additions to documentation dotfiles Configuration files for developer tools and CI/CD dependencies Updates to application dependency files test code Updates to the application or library test code source code Updates to the application or library source code clojure Clojure source code clojurescript ClojureScript source code labels Oct 17, 2024
(def common-beer-format-version
"The BeerXML version this library is based on."
1)


(def amount-cutoff 2.26796) ; 5 pounds in kilograms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

@@ -80,23 +85,23 @@


(def common-beer-format-default-mash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

mash/type mash/infusion
mash/step-temp 68.0
mash/step-time 60.0
mash/infuse-amount 10.0}}]})


(def common-beer-format-recipe-defaults
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clj-kondo] reported by reviewdog 🐶
Missing docstring.

@nnichols nnichols merged commit c77de96 into master Oct 17, 2024
12 checks passed
@nnichols nnichols deleted the clean-up-deps branch October 17, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clojure Clojure source code clojurescript ClojureScript source code dependencies Updates to application dependency files documentation Improvements or additions to documentation dotfiles Configuration files for developer tools and CI/CD source code Updates to the application or library source code test code Updates to the application or library test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants