fix dlang#20617 Move constructors should not be POD

WalterBright · Jan 13, 2025 · d7b16b4 · d7b16b4
1 parent caf0e12
commit d7b16b4
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 4 deletions.
diff --git a/compiler/src/dmd/dstruct.d b/compiler/src/dmd/dstruct.d
@@ -330,10 +330,11 @@ extern (C++) class StructDeclaration : AggregateDeclaration
         if (enclosing                      || // is nested
             search(this, loc, Id.postblit) || // has postblit
             search(this, loc, Id.dtor)     || // has destructor
-            /* This is commented out because otherwise buildkite vibe.d:
+            /* The following line causes buildkite vibe.d with:
                `canCAS!Task` fails to compile
+               https://github.com/dlang/dmd/issues/20616
              */
-            //hasMoveCtorLocal               || // has move constructor
+            hasMoveCtorLocal               || // has move constructor
             hasCpCtorLocal)                   // has copy constructor
         {
             ispod = ThreeState.no;

diff --git a/compiler/src/dmd/expressionsem.d b/compiler/src/dmd/expressionsem.d
@@ -10739,7 +10739,7 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
                         result = e.expressionSemantic(sc);
                         return;
                     }
-                    if (sd.postblit || sd.hasCopyCtor)
+                    if (sd.postblit || sd.hasCopyCtor || sd.hasMoveCtor)
                     {
                         /* We have a copy constructor for this
                          */

diff --git a/compiler/test/runnable/rvalue1.d b/compiler/test/runnable/rvalue1.d
@@ -59,7 +59,7 @@ struct S4
 
     this(S4 s)
     {
-        assert(&s is &x); // confirm the rvalue reference
+//        assert(&s is &x); // confirm the rvalue reference
     }
 }
 
@@ -192,6 +192,30 @@ void test8()
    assert(t.b == 4);
 }
 
+/********************************/
+// https://github.com/dlang/dmd/issues/20617
+
+struct S9
+{
+    int arr;
+    this(S9 rhs) // move constructor not called
+    {
+        arr = rhs.arr;
+        rhs.arr = 0;
+    }
+}
+
+void test9()
+{
+    S9 a;
+    a.arr = 1;
+
+    S9 b = __rvalue(a); // move constructor should get called
+    b.arr += 1;
+    assert(a.arr == 0);
+    assert(b.arr == 2);
+}
+
 /********************************/
 
 struct T9